Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Swift Strict Concurrency support #170

Merged
merged 23 commits into from
Apr 3, 2024

Conversation

adamayoung
Copy link
Owner

No description provided.

@adamayoung adamayoung linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 21.53846% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 88.41%. Comparing base (dca0aff) to head (5404028).

Files Patch % Lines
Sources/TMDb/TMDbFactory.swift 0.00% 17 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 3 Missing ⚠️
Sources/TMDb/TMDbConfiguration.swift 0.00% 3 Missing ⚠️
Sources/TMDb/Services/Account/AccountService.swift 0.00% 2 Missing ⚠️
...Services/Certifications/CertificationService.swift 0.00% 2 Missing ⚠️
Sources/TMDb/Services/Company/CompanyService.swift 0.00% 2 Missing ⚠️
.../Services/Configuration/ConfigurationService.swift 0.00% 2 Missing ⚠️
...urces/TMDb/Services/Discover/DiscoverService.swift 0.00% 2 Missing ⚠️
Sources/TMDb/Services/Genres/GenreService.swift 0.00% 2 Missing ⚠️
Sources/TMDb/Services/Movies/MovieService.swift 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   88.89%   88.41%   -0.49%     
==========================================
  Files         108      109       +1     
  Lines        2297     2288       -9     
==========================================
- Hits         2042     2023      -19     
- Misses        255      265      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamayoung adamayoung merged commit 17d8ace into main Apr 3, 2024
15 of 16 checks passed
@adamayoung adamayoung deleted the feature/conform-to-sendable branch April 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conform value types to Sendable
1 participant