Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TV Episode Data and Images #60

Merged
merged 17 commits into from
Aug 8, 2022
Merged

Add TV Episode Data and Images #60

merged 17 commits into from
Aug 8, 2022

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Aug 1, 2022 •
edited
Loading

Fixes #59

Changes

  • Added TV episode data and image URL fetching to the project.
  • Added image vote average and count metadata.

Notes

  • Episode images were tested by hand in a client app using my fork
  • Everything had unit tests added and pass.

@joeljfischer joeljfischer marked this pull request as draft August 1, 2022 20:02
@joeljfischer joeljfischer marked this pull request as ready for review August 1, 2022 20:29
@adamayoung
Copy link
Owner

adamayoung commented Aug 4, 2022 •
edited
Loading

@joeljfischer Thanks for your PR. Can you fix the linting issues and unit test failures?

@joeljfischer
Copy link
Contributor Author

Done and done

@adamayoung adamayoung merged commit 34950d5 into adamayoung:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TV Show Episode Data Is Missing
2 participants
@joeljfischer @adamayoung