Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asymptotic notation rough draft #950

Merged
merged 9 commits into from
Feb 2, 2015
Merged

Conversation

JakeHP
Copy link
Contributor

@JakeHP JakeHP commented Feb 1, 2015

I gave this a re-read through but would definitely appreciate several more sets of eyes reading over it....

Is this clear?
Not enough explanation? Too much?
I worry this is too short to actually grasp the concept, but I think it's enough to get a basic understanding?

Once this gets cleared/merged I plan on writing up a doc on Analyzing Algorithms (big oh notation application #526 (comment)).

JakeHP and others added 8 commits January 31, 2015 21:22
Fixing some grammar and incorrect usage of it's.
Replacing description of why not to use best case.
Changing some formatting to hopefully make it read a little easier.
Fixing newlines hopefully. Hard to tell in the editor.
More grammar fixes. Whitespace fixes for readability.
@levibostian
Copy link
Collaborator

Well done @JakeHP!

I am not quite sure how it is going to look as far as the site goes because this is a new section. The best way in my opinion to see is to merge it and see what it looks like and fix from there. So here it goes...

levibostian added a commit that referenced this pull request Feb 2, 2015
asymptotic notation rough draft
@levibostian levibostian merged commit f41adf8 into adambard:master Feb 2, 2015
@JakeHP
Copy link
Contributor Author

JakeHP commented Feb 2, 2015

@vendethiel
Copy link
Collaborator

I don't think the website builder is happy with so little metadata ;-).

@JakeHP
Copy link
Contributor Author

JakeHP commented Feb 3, 2015

So what's the plan on fixing this?

@vendethiel
Copy link
Collaborator

waiting for @adambard .. :)

@adambard
Copy link
Owner

adambard commented Feb 3, 2015

Right, on it.

@adambard
Copy link
Owner

adambard commented Feb 3, 2015

Ok, so, now you can add new categories by naming them as in this PR, but you need to add a name field (which I've done for this article). This is the same as the language field in languages or the tool field in tools, and is clearly better, but there's no way I'm going back and changing all those over individually :P

@JakeHP
Copy link
Contributor Author

JakeHP commented Feb 3, 2015

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants