This repository has been archived by the owner on May 20, 2020. It is now read-only.
Set a default for --token option #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonplend
force-pushed
the
token-option-default
branch
from
5e94054
to
6fe51c1
Compare
Based on the original implementation of this pattern in Ebi: https://github.com/Financial-Times/ebi/blob/176ab95da2371bb922aa671733198c10c6333d86/src/commands/shared.js#L16-L24
Each command has been updated to use the `token` option helper and `lodash.flow` has been used so that we can easily compose yargs options. https://lodash.com/docs/4.17.11#flow
simonplend
force-pushed
the
token-option-default
branch
from
6fe51c1
to
9116db3
Compare
adambraimbridge
approved these changes
Mar 20, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a nicer developer experience, we're now using the
GITHUB_PERSONAL_ACCESS_TOKENenvironment variable as the default value for the--tokenoption.Resolves #13.