-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create packet structure #55
Comments
@adambujak @harneetMac Here's my first stab at the packet structure. 40 represents the number of samples per gesture. Specifying the max/fixed count makes it easier to populate the arrays with data.
|
We could pad the message with a header/footer at transmission with something like (where 0x16 and 0x27 are arbitrary values):
|
if we're framing it ourselves i think we should add a crc |
Yeah a crc would be good to have. Also, it might make more sense to structure the data like this with a nested repeated message:
|
Protobuf doesn't support int16 as far as I'm aware |
yeah you are right |
I think they don't recommend required fields due to potential backwards compatibility issues if you change your packet structure. That's mostly a concern if you have an application with many users and you want to make sure users with old versions are still supported by the server in the future. For our case it makes sense for all fields to be required |
@adambujak @harneetMac What do you think of this structure? GestureData is only used on the Android side to construct the packet with all the GestureData. I was thinking including the letter in the data could make it easier for us for training. I.e. we can save a bunch of delimited protobuf packets to a file which we can copy to a desktop to train with. Also the sample packets include the sample id to ensure that the samples are placed in the correct order in the gesture data.
We would transmit Sample packets to the Android app padded like this:
|
Switching the touch sensors to bool brings the maximum encoded size down to 100 bytes:
|
No description provided.
The text was updated successfully, but these errors were encountered: