Fixed json cls encoder in trigger_client_event #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleitonDeLima
force-pushed
the
fix/django-json-encoder
branch
from
4b6a9a8
to
849bf02
Compare
adamchainz
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Thanks! I'll push a few commits to improve the test, and add docs and changelog note. When you make open source contributions, please try to update the docs and changelog too, in the style of the project. Without such changes your feature will be "secret" and no other users will discover it.
I added some review around the changes to the test below, which I'm taking care of.
|
Thanks for the tips @adamchainz , always good to learn! |
|
No worries, released in version 1.7.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #180