Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-template-partials example to Tips #413

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

carltongibson
Copy link

Hey @adamchainz 👋

I saw on the Fedi that you might accept an example using django-template-partials to the tips section, so I drafted one.

@adamchainz
Copy link
Owner

This project uses present tense PR titles/commit messages without a full-stop at the end, because that makes grammatical sense for a headline 😉

@adamchainz adamchainz changed the title Added django-template-partials example to Tips. Add django-template-partials example to Tips Jan 21, 2024
@adamchainz
Copy link
Owner

I like the start here, but I think we should have two sections. One to cover the “render a small portion of the page” style that django-template-partials is perfect for, and another for the “render the only main section” style that the current tip covers. I wrote the current tip after several people asked for it, but I think the django-template-partials style is more in-keeping with the htmx philosophy.

WDYT?

@carltongibson
Copy link
Author

Hey @adamchainz — It's your package, so happy to follow your lead. 😀

From what you wrote I can't quite work out if you mean:

  1. Have two examples using django-template-partials for the small snippet and just the main content (so add a second example to this PR) or...
  2. Replace the example I added here with just a small snippet case?

FWIW I'm using dtp for both IRL, but I'd rather add the example(s) you'd be happiest with here.

LMK and I'll update. 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants