Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixer to update BaseCommand.requires_system_checks #184

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Add fixer to update BaseCommand.requires_system_checks #184

merged 6 commits into from
Sep 7, 2022

Conversation

browniebroke
Copy link
Contributor

https://docs.djangoproject.com/en/dev/releases/3.2/#deprecated-features-3-2

Using a boolean value in BaseCommand.requires_system_checks is deprecated. Use '__all__' instead of True, and [] (an empty list) instead of False.

@browniebroke browniebroke marked this pull request as ready for review September 6, 2022 22:16
adamchainz
adamchainz reviewed Sep 6, 2022
View reviewed changes
Copy link
Owner

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, nice. This can be a real nuisance in some projects. I'm gonna just make the below little fixes.

src/django_upgrade/data.py Outdated Show resolved Hide resolved
src/django_upgrade/fixers/management_command.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@adamchainz adamchainz changed the title Rewrite BaseCommand.requires_system_checks boolean flag as a list of checks Add fixer to update BaseCommand.requires_system_checks Sep 7, 2022
@adamchainz adamchainz merged commit 32bc553 into adamchainz:main Sep 7, 2022
@adamchainz
Copy link
Owner

Yeah! 👍👏

@browniebroke browniebroke deleted the feat/command-system-checks branch September 7, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@browniebroke @adamchainz