Fix Content-Length and Content-Type #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Both Content-Length and Content-Type are HTTP headers, but they aren't picked up by the request header fixer because they don't start with the usual `HTTP_` prefix. Solution: Add failing tests and then fix them by checking for either the usual `HTTP_` prefix or comparing against the set of these two exceptional cases. Fixes: adamchainz#224
for more information, see https://pre-commit.ci
|
Thank you! 👍 Needed a small bugfix with parentheses, you might want to check that out. I also added a changelog note - if you could try add that in your future open source contributions, that would save maintainers work. |
|
Ah, thanks for the paren bugfix -- I was just opening this PR to go fix that.
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Both Content-Length and Content-Type are HTTP headers, but they aren't picked up by the request header fixer because they don't start with the usual
HTTP_prefix.Solution: Add failing tests and then fix them by checking for either the usual
HTTP_prefix or comparing against the set of these two exceptional cases.Fixes: #224