Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lookup_needs_distinct to lookup_spawns_duplicates #313

Conversation

browniebroke
Copy link
Contributor

Function is undocumented and was therefore renamed without deprecation in Django 4.0:

https://docs.djangoproject.com/en/4.0/releases/4.0/#miscellaneous

The undocumented django.contrib.admin.utils.lookup_needs_distinct() function is renamed to lookup_spawns_duplicates().

@browniebroke browniebroke marked this pull request as ready for review January 17, 2023 14:31
@adamchainz adamchainz force-pushed the feat/admin-lookup_needs_distinct-rename branch from 6263f8e to c0b8cae Compare February 11, 2023 11:41
@adamchainz
Copy link
Owner

Thanks! Another small fix towards greatness.

@adamchainz adamchainz changed the title Rename django.contrib.admin.utils.lookup_needs_distinct to lookup_spawns_duplicates Rename lookup_needs_distinct to lookup_spawns_duplicates Feb 11, 2023
@adamchainz adamchainz merged commit 0209875 into adamchainz:main Feb 11, 2023
@browniebroke browniebroke deleted the feat/admin-lookup_needs_distinct-rename branch February 25, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants