-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixer for required on_delete argument #61
Conversation
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 25 +1
Lines 765 793 +28
Branches 128 132 +4
=========================================
+ Hits 765 793 +28
Continue to review full report at Codecov.
|
6674dfa
to
3633b7f
Compare
3633b7f
to
5c00788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One thing is we could insert the argument first, after any positional args, rather than last. This would require passing the number of positional arguments through to add_on_delete_keyword
It's more informational than other field arguments.
That's a good point, also |
I made a commit and it looks okay to me, so merging! Thanks! |
Thanks for finishing it up 👍🏻 |
No description provided.