Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to version 2.0 #150

Closed
adamchainz opened this issue Nov 20, 2019 · 4 comments · Fixed by #166
Closed

Update to version 2.0 #150

adamchainz opened this issue Nov 20, 2019 · 4 comments · Fixed by #166

Comments

@adamchainz
Copy link
Owner

https://aws.amazon.com/blogs/security/defense-in-depth-open-firewalls-reverse-proxies-ssrf-vulnerabilities-ec2-instance-metadata-service/

This requires a new "knock" PUT request to get a session token before accessing any bits of data.
@adamchainz adamchainz mentioned this issue Mar 2, 2020
Open
ThrawnCA pushed a commit to ThrawnCA/ec2-metadata that referenced this issue Mar 6, 2020
use instance metadata service v2, adamchainz#150
c875f96 
- this is forked from version 1.8.0, but similar changes can apply to master
ThrawnCA pushed a commit to ThrawnCA/ec2-metadata that referenced this issue Mar 6, 2020
use instance metadata service v2, adamchainz#150
6c6c497 
- metadata tokens are cached for up to 6 hours
@ThrawnCA
Copy link
Contributor

ThrawnCA commented Mar 6, 2020

Can this also be backported to v1.8.0?

ThrawnCA pushed a commit to ThrawnCA/ec2-metadata that referenced this issue Mar 6, 2020
update unit tests to handle IMDS v2, adamchainz#150
ff06d08
ThrawnCA pushed a commit to ThrawnCA/ec2-metadata that referenced this issue Mar 6, 2020
reformat with 'black', adamchainz#150
8e05311
ThrawnCA pushed a commit to ThrawnCA/ec2-metadata that referenced this issue Mar 6, 2020
clean up import order, adamchainz#150
ef6fe9b 
- multilint now passes locally
@adamchainz
Copy link
Owner Author

I won't backport since I only do Python 2 for money these days. But feel free to fork.

@ThrawnCA
Copy link
Contributor

ThrawnCA commented Mar 6, 2020

I won't backport since I only do Python 2 for money these days. But feel free to fork.

Is there a way to make it compatible with both? The code didn't look drastically different between 1.8 and current.

@adamchainz
Copy link
Owner Author

The problem is that I manage all 19 of my current OSS projects the same way. It takes extra effort to my general tooling and mental load to ensure things work on Python 2. Forking is not hard, you can pip install from github pretty easily.

@ThrawnCA ThrawnCA mentioned this issue Mar 12, 2020
Merged
adamchainz pushed a commit that referenced this issue Mar 12, 2020
@ThrawnCA
use instance metadata service v2 (#166)
3bdc89c 
Fixes #150.

Co-authored-by: antuarc <carl.antuar@smartservice.qld.gov.au>
@adamchainz adamchainz mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use instance metadata service v2 ThrawnCA/ec2-metadata
2 participants
@adamchainz @ThrawnCA