Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violation codes shadow flake8-import-order #106

Closed
labrys opened this issue Jun 23, 2018 · 4 comments · Fixed by #176
Closed

Violation codes shadow flake8-import-order #106

labrys opened this issue Jun 23, 2018 · 4 comments · Fixed by #176

Comments

@labrys
Copy link

labrys commented Jun 23, 2018

I201: Banned import 'foo' used is also used by flake8-import-order as I201: Missing newline between import groups.

@adamchainz
Copy link
Owner

Ok, so you think this library should change?

@labrys
Copy link
Author

labrys commented Jun 24, 2018

Personally I think the flake8 error code system should change, but that's neither here nor there 😁
Of course it's up to you to decide, but right now the two aren't compatible. I would recommend changing flake8-tidy-imports to higher I2xx codes.

@adamchainz
Copy link
Owner

Could you open a PR adding +50 to them all? thx

@labrys
Copy link
Author

labrys commented Jun 24, 2018

Sure will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants