Tidy messages for python2to3 #62
Conversation
|
WIP |
flake8_tidy_imports.py
Outdated
| 'cStringIO.cStringIO': 'moved in Python 3. io.BytesIO can be used as a drop-in replacement', | ||
| 'cStringIO.StringIO': 'moved in Python 3. six.moves.cStringIO can be used as a drop-in replacement', | ||
| 'Dialog': 'moved in Python 3. six.moves.tkinter_dialog can be used as a drop-in replacement', | ||
| 'commands': 'removed in Python 3, use subprocess', |
There was a problem hiding this comment.
I like most of the shorter messages, since "moved in python 3" doesn't add extra extra information, but I'm a fairly disappointed to see the "drop-in replacement" language removed.
Some libraries are not precise substitutes. "Drop-in replacement" means that I devoted effort to checking they're the same. For example, this PR makes commands (for which subprocess is not a drop-in replacement) have the same message as ConfigParser (for which six.moves.configparser is a drop-in replacement). Some of the other cases may in fact be exact substitutes or I may have made errors, but I've found this to be useful information.
If I'd known you were going to remove those, I would not have bothered to submit the PR originally, since this will make the released version much less useful than my previous bulky configuration file.
There was a problem hiding this comment.
Sorry, this is still WIP, I haven't made my mind up. Thanks for pointing this out, maybe we should be calling out the NON drop in replacements instead? Also I've been thinking about adding detection for non-from-imports too.
adamchainz
force-pushed
the
python2to3_tidy
branch
from
7fa5183
to
dcc363b
Compare
My logic here: anything mentioning a `six` replacement doesn't need mention of Python 2/3 because that's what six is. For everything else, mention if it was removed or moved, and point to the solution.
adamchainz
force-pushed
the
python2to3_tidy
branch
from
dcc363b
to
33888b2
Compare
|
@lucaswiman finally got around to finishing this up. I kept the "as a drop-in replacement" language since I think it's still the clearest way to explain this, so this change isn't doing so much. I've made #63 for future detection of using of banned imports later in the code, it's a lot harder since it involves name resolution in the code. |
|
This is great, @adamchainz! Thanks so much! |
My logic here: anything mentioning a
sixreplacement doesn't need mention of Python 2/3 because that's what six is. For everything else, mention if it was removed or moved, and point to the solution.