This repository has been archived by the owner on May 11, 2021. It is now read-only.
Remove inline NEXUS definition #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,19 +81,22 @@ | |||
| * Public, $.facebox methods | |||
| */ | |||
|
|
|||
| var nexusMediaPreix = $('#nexus-facebox-constants').attr('data-nexus-media-prefix'), | |||
| closeImage = nexusMediaPrefix + 'nexus/img/facebox/closelabel.gif'; | |||
|
|
|||
| $.extend($.facebox, { | |||
There was a problem hiding this comment.
eventually this should be moved into nexus's own JS so you can update facebox.js to 1.3 from https://github.com/defunkt/facebox
Sadly this version of 1.2 and the upstream version have significant changes
|
I added the HTML escaping and fixed your typo |
This was referenced Jan 9, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To comply with the Django 1.10 JavaScript deployment guidelines and CSP without unsafe-inline.