Skip to content

Commit

Permalink
Adding TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
adamcharnock committed Apr 17, 2018
1 parent b2fd495 commit 6eca6aa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lightbus/transports/redis.py
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ async def fetch_loop():
await queue.put(message)

async def reclaim_loop():
# TODO: Test reclaiming
await asyncio.sleep(self.acknowledgement_timeout)
async for message in self._reclaim_lost_messages(stream_names, consumer_group):
await queue.put(message)
Expand All @@ -430,6 +431,7 @@ async def _fetch_new_messages(self, streams, consumer_group, forever):

# Get any messages that this consumer has yet to process.
# This can happen in the case where the processes died before acknowledging.
# TODO: Test that pending messages get picked up
pending_messages = await redis.xread_group(
group_name=consumer_group,
consumer_name=self.consumer_name,
Expand Down

0 comments on commit 6eca6aa

Please sign in to comment.