Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caliper packages and GrandTourIT to core #65

Merged

Conversation

adamcin
Copy link
Owner

@adamcin adamcin commented Aug 28, 2020

I happen to know that subPackageHandling is not fully respected by OakMachine in terms of defining installation order of subpackages, and I wanted to have this kind of happy path test package available before I implemented the sorting. The other justifications for including this content package graph as first-order maven modules instead of just prebuilding a zip or nesting directories of flat files like other test packages include:

  • better tracking of the evolution of the filevault-package-maven-plugin and the resulting artifacts
  • more obvious relationship at a glance between AEM maven project conventions and progress check logic
  • publishing a valid, complex content package artifact to maven central will make it available for use as a test artifact in other contexts downstream

@adamcin
Copy link
Owner Author

adamcin commented Aug 28, 2020

@justinedelson please take a look at this

@adamcin adamcin merged commit 21263de into rebase-jcrinstall-stuff Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant