-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Castle.Core 4.4.0 / Castle.Windsor 5.0.0 #6
Upgrade to Castle.Core 4.4.0 / Castle.Windsor 5.0.0 #6
Conversation
Adam, It is strange that Travis fails and locally all tests are green on the full .Net framework v4.7.2. |
Thanks Danny, I'll take a look at this at the weekend. I originally setup the build to run on mono because I think it was the only option I could find at the time, but I think I can change that now. |
Danny - just to keep you in the loop, I'm setting up an Azure Pipelines build for this project and switching it to using a Windows build agent. Once I've done that we can double check if the build works against your branch. I'm just having a bit of trouble getting the build's version number passed through to msbuild at the moment. I'll try to get this sorted as soon as I can. |
Adam, Thank you for the fast response, if you need some help, say it. |
Hey Danny - I've updated the repo to use Azure Pipelines for building. The build should run on a Windows agent with VS 2017. Can you rebase your changes against master and update your PR and we can check if they build correctly? If so, we can get them merged, and I'll remove the Travis build. |
06df665
to
82e093c
Compare
Hi Adam, Build on Azure is green, but the tests didn't run there? |
I think they did - you can see them in the build log. I think I just need to configure it to output the tests in a way that pipelines can pick up. When I've got another bit of spare time I'll sort that, remove the Travis builds and get your change merged. |
Danny - that should be the test results sorted. If you rebase again it should show up correctly. Once that's done I'll get your changes merged and publish a new release. |
82e093c
to
d955194
Compare
Rebases and all green :) |
Great - thanks a lot Danny! I'll get this merged and publish a new version. |
Hi Danny, just to let you know that's the updated package published. It's available at https://www.nuget.org/packages/WindsorAppConfigFacility/1.2.0.26. Thanks again for the contribution. Unfortunately I'm not using Windsor on a day to day basis at the moment so I'm a bit out of touch, so it's great that you're willing to help out. |
New packages were NOT backward compatible, due to changes in internal classes.
For more information:
Castle.Windsor: Issue #444