Skip to content

Commit

Permalink
feat: add boolean for storing two factor skip state
Browse files Browse the repository at this point in the history
  • Loading branch information
adamcooke committed May 3, 2022
1 parent afb25ce commit ec834df
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# frozen_string_literal: true

class AddTwoFactorRequiredToSessions < ActiveRecord::Migration[4.2]
def change
add_column :authie_sessions, :skip_two_factor, :boolean, default: false
end
end
4 changes: 3 additions & 1 deletion lib/authie/session.rb
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ def see_password
#
# @raises [ActiveRecord::RecordInvalid]
# @return [Authie::Session]
def mark_as_two_factored
def mark_as_two_factored(skip: false)
@session.two_factored_at = Time.now
@session.two_factored_ip = @controller.request.ip
@session.skip_two_factor = skip
@session.save!
Authie.config.events.dispatch(:marked_as_two_factor, self)
self
Expand Down Expand Up @@ -304,6 +305,7 @@ def get_session(controller)
delegate :two_factored_at, to: :session
delegate :two_factored_ip, to: :session
delegate :two_factored?, to: :session
delegate :skip_two_factor, to: :session
delegate :update, to: :session
delegate :update!, to: :session
delegate :user_agent, to: :session
Expand Down
10 changes: 10 additions & 0 deletions spec/lib/session_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,16 @@
expect(Authie.config.events).to receive(:dispatch).with(:marked_as_two_factor, session)
session.mark_as_two_factored
end

it 'can set the skip two factor boolean to true if provided' do
session.mark_as_two_factored(skip: true)
expect(session.skip_two_factor).to eq true
end

it 'does not set the skip two factor boolean if not set' do
session.mark_as_two_factored
expect(session.skip_two_factor).to eq false
end
end

describe '#reset_token' do
Expand Down

0 comments on commit ec834df

Please sign in to comment.