Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More views / rework existing ones #177

Open
itfranck opened this issue Oct 11, 2020 · 1 comment
Open

More views / rework existing ones #177

itfranck opened this issue Oct 11, 2020 · 1 comment
Assignees

Comments

@itfranck
Copy link
Collaborator

  • Driver view: Switch the actual property to virtual ones.
  • Iwebelement view, include a special view to load selected attributes when selected through a special virtual property.

The objective is to provide more useful information at a glance without changing the actual properties.

For instance, Get-SeFrame now have its own view to return name / id, making it easy to swtich without digging further in.
image

@itfranck itfranck added this to the V4.0 milestone Oct 11, 2020
@itfranck itfranck self-assigned this Oct 11, 2020
@itfranck itfranck added this to In progress in V4.0 Oct 14, 2020
@itfranck itfranck removed this from the V4.0 milestone Dec 5, 2020
@itfranck itfranck added this to To Do in V4.0 - Preview2 via automation Dec 5, 2020
@itfranck
Copy link
Collaborator Author

itfranck commented Dec 6, 2020

I finally started the work on this:

Take this screen for instance.
image

Old view:

image

New view:
image

The old view is barely useful and requires to do more digging to pick up the correct input.
The new view provide the input type and the UI component (Text / Placeholder / value)
The * is to signify these are virtual properties and thus, they are not directly accessible through

$Inputs = Get-SeInput 
$Inputs.type

They are part of the automatically loaded attribute for object of these type.

$Inputs.Attributes.type
$Inputs.Attributes.placeholder
$Inputs.Attributes.value

Maybe Text / Placeholder / Value should be combined in 2 fields: HInt / HintType
HintType would contains Text/Placeholder/Value
Hind would contains the text that was picked up (Priority: Text > Placeholder > Value)

I think I'll stick with the former logic for now and continue to evaluate if I stick with it for Preview3

Edit:

Start-SeDriver -Browser Chrome -Position 1920x0 -StartURL 'semantic-ui.com/elements/input.html' 

Testing with a page containing more inputs, we can see more the value of the latter idea.
Screen space is a commodity so merging Text / PlaceHolder / Value into HintType / Hint and define Hint to 80 width (max width) will allow to see a bit more of what's going on.

image

itfranck added a commit that referenced this issue Dec 6, 2020
itfranck added a commit that referenced this issue Dec 6, 2020
* Start-SeEdgeDriver throw error on launch (#188)

* Edge fix + general debug fix

* .Where is not a method for CIM Instance object (#190)

* Firefox not using the proper DriverOption (#191)

* Filter parameter to get-seelement and applied to Get-SeInput (#186 #192 )

Also fixed a logic error with $Value that was used both as a parameter and a variable, which caused issues.

* Legacy code removal causing error with screenshots (#187)

* Fix - Filter + Filter error message

* Select input by attributes fix.

* Edge (new) driver option need to be of type ChromeOptions (#195)

* Edge driver option fix (#193)

* Edge - semi revert (#197)

Since Start-SeDriver have priority over options, options should not handle stuff that depends on parameters.

* IE fix (#193)

* MSEdge Fix (#193)

* ErrorAction Stop when MSEdge Service fail to create.

* AcceptInsecureCertificates (Firefox, Chrome, Edge) (#189)

* #177 Get-SeInput view (initial commit)

* V4.0.0-preview2 build

* Drivers update

* V4.0.0-preview2 changelog

* Version update
@itfranck itfranck removed this from To Do in V4.0 - Preview2 Dec 6, 2020
@itfranck itfranck removed this from In progress in V4.0 Dec 6, 2020
@itfranck itfranck added this to the v4.0.0-preview3 milestone Dec 6, 2020
@itfranck itfranck removed this from the v4.0.0-preview3 milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant