Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to make toolbar icon size bigger ? #385

Open
huangyy opened this issue May 3, 2023 · 12 comments
Open

how to make toolbar icon size bigger ? #385

huangyy opened this issue May 3, 2023 · 12 comments

Comments

@huangyy
Copy link

huangyy commented May 3, 2023

In high resolution (for example 4K), the toolbar icon size look small, how to make it bigger ?

@adamdruppe
Copy link
Owner

you on windows or linux?

@huangyy
Copy link
Author

huangyy commented May 3, 2023

win10

@adamdruppe
Copy link
Owner

I don't know how to do it on Windows.... need bigger icons and I think there's some in the operating system but I haven't figured out how to use them yet.

@adamdruppe
Copy link
Owner

I found a thing that is 50% bigger, 24x24 instead of 16x16. That is easy to swap out to at least. Still might be too small for a 4k though.

@adamdruppe
Copy link
Owner

Just pushed a commit to master that uses the larger size of scaling is on.

I might change it though, right now it turns on if scaling is at 125% or above, but it might be too big at 125 so maybe I should make it turn on only at 150%... if you can use master let me know how you like this,

@huangyy
Copy link
Author

huangyy commented May 4, 2023

I found another solution. In win10, select EXE properties, select compatibility, click "Change high DPI settings", check "Override high DPI scaling behavior", and select "System enhancements". so, toolbar Icon size look normal.
My OS is in Chinese, so I don't know if some of the text on the operating system is accurate.

@huangyy
Copy link
Author

huangyy commented May 4, 2023

The new commit compiles with errors.
PS D:\dev\dlang\minigui> dub --build=release --arch=x86_64 --compiler=ldc2
Starting Performing "release" build using ldc2 for x86_64.
Building arsd-official:color_base 10.9.10: building configuration [library]
Building arsd-official:simpledisplay 10.9.10: building configuration [normal]
Building arsd-official:minigui 10.9.10: building configuration [library]
C:\Users\huang\AppData\Local\dub\packages\arsd-official-10.9.10\arsd-official\minigui.d(220,8): Error: unable to read module core
C:\Users\huang\AppData\Local\dub\packages\arsd-official-10.9.10\arsd-official\minigui.d(220,8): Expected 'arsd\core.d' or 'arsd\core\package.d' in one of the following import paths:

PS D:\dev\dlang\minigui> dub --build=release --arch=x86_64 --compiler=ldc2
Starting Performing "release" build using ldc2 for x86_64.
Building arsd-official:color_base 10.9.10: building configuration [library]
Building arsd-official:simpledisplay 10.9.10: building configuration [normal]
Building arsd-official:minigui 10.9.10: building configuration [library]
C:\Users\huang\AppData\Local\dub\packages\arsd-official-10.9.10\arsd-official\minigui.d(8912,11): Error: constructor arsd.simpledisplay.WindowsApiException.this(string msg, string file = __FILE__, ulong line = cast(ulong)__LINE__, Throwable next = null) is not callable using argument types (string, uint)
C:\Users\huang\AppData\Local\dub\packages\arsd-official-10.9.10\arsd-official\minigui.d(8912,11): cannot pass argument GetLastError() of type uint to parameter string file = __FILE__
Error ldc2 failed with exit code 1.

@adamdruppe
Copy link
Owner

You must update the whole repository at once to use the new version, it depends on changes in three other files. I don't know if dub can even do it yet without a config file update.

@huangyy
Copy link
Author

huangyy commented May 5, 2023

Just pushed a commit to master that uses the larger size of scaling is on.

I might change it though, right now it turns on if scaling is at 125% or above, but it might be too big at 125 so maybe I should make it turn on only at 150%... if you can use master let me know how you like this,

set "arsd-official:minigui": "~master" in dub.json to use master, but toolbar icon size looks a little small. :)
screenshot:
https://github.com/huangyy/myimage/blob/main/%E5%B1%8F%E5%B9%95%E6%88%AA%E5%9B%BE%202023-05-06%20002035.png

@adamdruppe
Copy link
Owner

Is that bigger than the old one? Just not big enough?

@huangyy
Copy link
Author

huangyy commented May 6, 2023

Bigger than the old one, but not big enough.

@adamdruppe
Copy link
Owner

ok, i guess what i have to do is take the small one and double it. then i can take 16, 24, 32, and 48 pixel options by doubling the two i have.

gonna be a little while until i get around to it though

kinda weird the OS isn't doing it for me, the toolbar is OS provided and the icons on it are OS provided too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants