Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove deprecated gulp-util dependency #213

Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 4.0.2

* Remove deprecated [`gulp-util`](https://github.com/gulpjs/gulp-util) dependency and use individual modules instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the last . for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


## 4.0.1

* Make `fix` option work even if `quiet` option is also enabled
Expand Down
4 changes: 2 additions & 2 deletions example/fail.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// npm install gulp gulp-eslint

const gulp = require('gulp');
const gulpUtil = require('gulp-util');
const fancyLog = require('fancy-log');
const eslint = require('../');

gulp.task('fail-immediately', () => {
Expand All @@ -15,7 +15,7 @@ gulp.task('fail-immediately', () => {
.pipe(eslint.failOnError())
// need to do something before the process exits? Try this:
.on('error', error => {
gulpUtil.log('Stream Exiting With Error: ' + error.message);
fancyLog('Stream Exiting With Error: ' + error.message);
});
});

Expand Down
6 changes: 3 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const PluginError = require('gulp-util').PluginError;
const PluginError = require('plugin-error');
const CLIEngine = require('eslint').CLIEngine;
const util = require('./util');
const path = require('path');
Expand Down Expand Up @@ -164,7 +164,7 @@ gulpEslint.failAfterError = () => {
* Format the results of each file individually.
*
* @param {(String|Function)} [formatter=stylish] - The name or function for a ESLint result formatter
* @param {(Function|Stream)} [writable=gulp-util.log] - A funtion or stream to write the formatted ESLint results.
* @param {(Function|Stream)} [writable=fancy-log] - A funtion or stream to write the formatted ESLint results.
* @returns {stream} gulp file stream
*/
gulpEslint.formatEach = (formatter, writable) => {
Expand All @@ -178,7 +178,7 @@ gulpEslint.formatEach = (formatter, writable) => {
* Wait until all files have been linted and format all results at once.
*
* @param {(String|Function)} [formatter=stylish] - The name or function for a ESLint result formatter
* @param {(Function|stream)} [writable=gulp-util.log] - A funtion or stream to write the formatted ESLint results.
* @param {(Function|stream)} [writable=fancy-log] - A funtion or stream to write the formatted ESLint results.
* @returns {stream} gulp file stream
*/
gulpEslint.format = (formatter, writable) => {
Expand Down
Loading