Extracted no-op filter into static final

adamfisk · Apr 11, 2016 · 134ebc6 · 134ebc6
1 parent 2db9f31
commit 134ebc6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/org/littleshoot/proxy/HttpFiltersAdapter.java b/src/main/java/org/littleshoot/proxy/HttpFiltersAdapter.java
@@ -11,6 +11,11 @@
  * Convenience base class for implementations of {@link HttpFilters}.
  */
 public class HttpFiltersAdapter implements HttpFilters {
+    /**
+     * A default, stateless, no-op {@link HttpFilters} instance.
+     */
+    public static final HttpFiltersAdapter NOOP_FILTER = new HttpFiltersAdapter(null);
+
     protected final HttpRequest originalRequest;
     protected final ChannelHandlerContext ctx;
 

diff --git a/src/main/java/org/littleshoot/proxy/impl/ClientToProxyConnection.java b/src/main/java/org/littleshoot/proxy/impl/ClientToProxyConnection.java
@@ -36,7 +36,6 @@
 import java.io.IOException;
 import java.net.InetSocketAddress;
 import java.net.UnknownHostException;
-import java.nio.channels.ClosedChannelException;
 import java.nio.charset.Charset;
 import java.util.Date;
 import java.util.List;
@@ -124,7 +123,7 @@ public class ClientToProxyConnection extends ProxyConnection<HttpRequest> {
     /**
      * The current filters to apply to incoming requests/chunks.
      */
-    private volatile HttpFilters currentFilters = new HttpFiltersAdapter(null);
+    private volatile HttpFilters currentFilters = HttpFiltersAdapter.NOOP_FILTER;
 
     private volatile SSLSession clientSslSession;
 
@@ -221,7 +220,7 @@ private ConnectionState doReadHTTPInitial(HttpRequest httpRequest) {
         if (filterInstance != null) {
             currentFilters = filterInstance;
         } else {
-            currentFilters = new HttpFiltersAdapter(null);
+            currentFilters = HttpFiltersAdapter.NOOP_FILTER;
         }
 
         // Send the request through the clientToProxyRequest filter, and respond with the short-circuit response if required