java.lang.NumberFormatException using IPv6 addresses

[asoldano]

Hi,
I'm using version 0.4. The HttpRequestHandler chokes on IPv6 addresses:

2012-03-15 18:49:52,095 INFO [org.littleshoot.proxy.HttpRequestHandler:607] Caught an exception on browser to proxy channel: [id: 0x27972e3a, /0:0:0:0:0:0:0:1:49725 => /0:0:0:0:0:0:0:1:19385]
java.lang.NumberFormatException: For input string: ":1]:8080"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.parseInt(Integer.java:499)
at org.littleshoot.proxy.HttpRequestHandler.newChannelFuture(HttpRequestHandler.java:450)
at org.littleshoot.proxy.HttpRequestHandler.processMessage(HttpRequestHandler.java:321)
at org.littleshoot.proxy.HttpRequestHandler.messageReceived(HttpRequestHandler.java:213)
at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:302)
at org.jboss.netty.handler.codec.replay.ReplayingDecoder.unfoldAndfireMessageReceived(ReplayingDecoder.java:522)
at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:506)
at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:443)
at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274)
at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261)
at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349)
at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280)
at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)

Below is a patch for solving this:

diff --git a/src/main/java/org/littleshoot/proxy/HttpRequestHandler.java b/src/main/java/org/littleshoot/proxy/HttpRequestHandler.java
index 864b7f0..7563207 100644
--- a/src/main/java/org/littleshoot/proxy/HttpRequestHandler.java
+++ b/src/main/java/org/littleshoot/proxy/HttpRequestHandler.java
@@ -443,15 +443,30 @@ public class HttpRequestHandler extends SimpleChannelUpstreamHandler
final Channel browserToProxyChannel) {
final String host;
final int port;

•    if (hostAndPort.contains(":")) {
  

•        host = StringUtils.substringBefore(hostAndPort, ":");
  

•        final String portString = 
  

•            StringUtils.substringAfter(hostAndPort, ":");
  

•        port = Integer.parseInt(portString);
  

•    }
  

•    else {
  

•        host = hostAndPort;
  

•        port = 80;
  

•    if (hostAndPort.contains("[") && hostAndPort.contains("]")) {
  

•       int idx = hostAndPort.lastIndexOf("]");
  

•       int cIdx = hostAndPort.lastIndexOf(":");
  

•       if (cIdx > idx) {
  

•          host = hostAndPort.substring(0, idx + 1);
  

•          final String portString = 
  

•              hostAndPort.substring(cIdx + 1);
  

•          port = Integer.parseInt(portString);
  

•       }
  

•       else {
  

•          host = hostAndPort;
  

•          port = 80;
  

•       }
  

•    } else {
  

•       if (hostAndPort.contains(":")) {
  

•           host = StringUtils.substringBefore(hostAndPort, ":");
  

•           final String portString = 
  

•               StringUtils.substringAfter(hostAndPort, ":");
  

•           port = Integer.parseInt(portString);
  

•       }
  

•       else {
  

•           host = hostAndPort;
  

•           port = 80;
  

•       }
   }
  
   // Configure the client.
  

Please evaluate.
Thanks

[jekh]

I was a little surprised when I discovered that this issue still exists! I just submitted PR #211 which should fix it.

[adamfisk]

Fixed in #211