Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of LittleProxy 0.5.3 to work with Netty 3.10.4.Final #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-beckmann
Copy link

Hi,

here you find changes necessary to make LittleProxy 0.3.5 compatible to Netty 3.10.4.Final. The changes are quite simple, involve just changing the access to HTTP header which was refactored on the Netty side in the meantime. These changes are valuable to people having ChannelHandlers plugged into LittleProxy which are not ported yet to Netty 4.

If you find this valueable, you may want to merge based on the littleproxy-0.3.5 tag and create a 0.3.5.1 or 0.3.6 or so...

Best regards,
Thomas Beckmann.

@t-beckmann
Copy link
Author

Notice, GitHub did not let me select 0.3.5 as the base. So I guess one has to merge manually at the command line...

@ganskef
Copy link
Collaborator

ganskef commented Jul 29, 2015

Thank you Thomas, I think, it's a valuable contribution, but I've to figure out how to work with such an old branch. @jekh Do you think, it could be released with LittleProxy, if I build it?

@jekh
Copy link
Collaborator

jekh commented Jul 30, 2015

@ganskef - we could make a branch for Netty 3 support, and @t-beckmann could submit the PR against that branch. It should be fairly simple to do. I don't see any harm having a branch with a Netty 3-compatible build, if folks find it useful. But it's old enough that I wouldn't expect to have any more maven releases of the Netty 3 build.

@ganskef ganskef self-assigned this Jul 30, 2015
@ganskef
Copy link
Collaborator

ganskef commented Aug 2, 2015

@t-beckmann I've created a branch, but I'm not sure about the naming https://github.com/ganskef/LittleProxy/tree/netty-3.10, see #229

@jekh
Copy link
Collaborator

jekh commented Aug 2, 2015

I think a netty-3 branch in the main LittleProxy repository would be fine. Or if you'd prefer to maintain the netty 3-compatible port separately, I don't see any issues with that, either.

@ganskef
Copy link
Collaborator

ganskef commented Aug 3, 2015

@t-beckmann would you like to maintain the netty 3-compatible port in your repository?

You could create a request with an addition to the README. (Or I could do this for you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants