Add netty-4.1 profile for testing #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is only for testing purposes, I'll go ahead and merge it. Once PR #240 is merged, the tests under Netty 4.1 will pass. |
jekh
added a commit
that referenced
this pull request
Sep 20, 2015
Add netty-4.1 profile for testing
|
Thanks Jason!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change makes testing LittleProxy against Netty 4.1 a bit easier. For example:
mvn clean test -P netty-4.1Will run all our tests against the Netty 4.1 version specified in the profile (currently 4.1.0.Beta6).
The profile is not and should not be used for releases, and has no effect whatsoever on travis-ci builds.