New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests for Collector to work with Osmium #51
Comments
I took a crack at this here Will need a bit more work but would appreciate a peer review before I continue refining it. The problems this cause seem to be limited to the tests in Since WayCollector can only parse via its parent's Having done this, all tests except A few more notes:
|
Thanks for your work on this @darylmatuszak ! :-) I've made a small tweak in 30de14e to get the tests running on Python 3.5 and will take a look at the failures and give it a more full review. |
A note to myself: I needed to upgrade osmium from 2.14.3 to 2.15.4 in order to get the fix for wrong precision being written: osmcode/pyosmium#83 |
I took a look at All tests are passing now in my test-compatability branch-- getting this working again is a great improvement. I'll be away from the computer for the weekend, but 👍 on continuing this work. |
Nice! Appreciate your expertise on sorting out that failure. pyosmium is aware of the deprecation warning, and it seems to be coming from pybind11. This is a cool project, and certainly one I will be getting a lot of mileage out of :) As I continue to become more familiar, I hope to find further areas where I can make a contribution. |
Thanks again for your help on this issue, @darylmatuszak! I've merged in your your work. I've been hard at work on a new in-browser map for Curvature over the past few months and haven't been giving the underlying code the love it deserves recently. Now that the new map is launched I'm hoping to find some more time for some features I've put on hold. :-) |
9b0fa2a converted from using the
imposm.parser
to the Osmium PBF parser. In the process, the Collector API changed and dropped theparser_class
argument that had been used for wiring in test structures for unit testing.The text was updated successfully, but these errors were encountered: