Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically added child components are doesn't work correctly #499

Closed
towan912 opened this issue Jan 10, 2023 · 2 comments
Closed

Dynamically added child components are doesn't work correctly #499

towan912 opened this issue Jan 10, 2023 · 2 comments

Comments

@towan912
Copy link

Dynamically added child components are cannot call parent component functions or events.
If the parent component is not inherited, it will render correctly.

I'm setting up morphdom.

The version of the unicorn is 0.49.2.

@towan912
Copy link
Author

I'll have to look into this in more detail, but I suspect the problem is that the #430 fix creates a new UnicornView without using the View of the parent component that was passed to the child component.

@adamghill
Copy link
Owner

I think this should be fixed by 0.58.0 of Unicorn which drastically improves child components so I'm going to close it. If it is still a problem feel free to re-open this and create a failing test or small example in the example app of this repo to replicate, though. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants