Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[startunicorn] Extract methods from loop #642

Merged
merged 7 commits into from
Feb 25, 2024

Conversation

felipmartins
Copy link
Contributor

Doing this we're solving two noticed bugs;

  • Preventing the ask_for_star message from spamming;
  • Fixing the folder creation for nested components[1];

[1] I've noticed that creating two nested components in a row python3 manage.py startunicorn app test_1.test_2.table test_3.test_4.row goes wrong beacuse of component_base_path variable.

I also needed to add the creation os app/templates/unicorn to test file.

Hope it helps! :)

@adamghill
Copy link
Owner

Thank you! I'll merge this in for the next release. 👍

@adamghill adamghill merged commit e5f41a4 into adamghill:main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants