Potential fix for #647 #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamghill
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
This looks good at first glance. I have an in-flight change here for Django models as well.
One thing I know will need to happen is handling Pydantic not being installed since it's optional. If you want to do that it would be rad, otherwise I'll get to it as soon I can.
|
@all-contributors add @siliconcow for code and tests |
|
I've put up a pull request to add @siliconcow! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647
Not super familiar with the codebase but this seems to work.