Added support for dir value for organizer - for PR 132 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* README.md
- Updated to include organizer.dir
* src\schema\index.js
- Updadet organizer schema to include dir
* src\utils\fold-line.js
- Changed approach from building an array that joins at the end, to a string concat approach, which is about 4 times faster, which seemed appropriate, for the function that is called the most.
* src\utils\format-date.js
- Extracted isArray() check to be only done once
* src\utils\set-alarm.js
- Swapped setDuration() function with formatDuration(), since it is duplicate code
* test\pipeline\build.spec.js
- Added dir attribute to the organizer objects
* test\pipeline\format.spec.js
- Added dir attribute to the organizer objects
* test\schema\index.spec.js
- Added dir attribute to the organizer objects
adamgibbons
added a commit
that referenced
this pull request
Jun 5, 2021
This reverts commit 4759444.
adamgibbons
added a commit
that referenced
this pull request
Jun 5, 2021
|
@MaikHannemann thanks for this - there was however one failing test, so I've reverted. Happy to merge again if you can fix that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that is being addressed: #132