PR to add mysql_port, default values and minor other changes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyTromp
commented
Jul 1, 2022
TonyTromp
commented
- Added mysql_port (which can be used for kubernetes nodePorts or when there are more instances on host).
- Added docker-compose file with build instructions
- Added default values if environment params are not set
adamhancock
reviewed
Jul 4, 2022
| spec: | ||
| containers: | ||
| - name: mysql-backup-azure | ||
| image: adamhancock/mysql-backup-to-azure:develop | ||
| image: mysql-to-azure-backup |
There was a problem hiding this comment.
Hi, thanks for your PR but changing the image name to remove the username prefix will result in image not found?
| build: | ||
| dockerfile: Dockerfile | ||
| context: . | ||
| image: mysql-to-azure-backup:latest |
There was a problem hiding this comment.
The same issue with this image name.
There was a problem hiding this comment.
its because your configuration always uses the image you have uploaded to Docker Hub, and not using the locally build one at all.
To build docker image locally simply run:
- docker-compose build
to run it (once) - docker-compose up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.