Introduced IArchiveFactory #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the interface is pretty much ready for review |
adamhathcock
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in #670 , I've introduced the
IArchiveFactoryinterface, with the bare minimum methods required to keep all the funcionality, and the factory implementations for each archive type.Also, added the
RegisterFactorymethod inArchiveFactoryand adjusted theOpenmethod to use the registered factories instead of the fixed list.remaining issues:
Not sure to which factory should I assign some extensions lik .LZ
In ArchiveFactory there's some more Open methods that still use the fixed list, I guess they should be redirected to the Open method that uses the factory collection.