Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license in nuget package #684

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

daverant
Copy link
Contributor

@daverant daverant commented Jul 18, 2022

Some licensing tools I use (Snyk) were failing to identify SharpCompress' MIT license as it's not bundled into the Nuget package. This bundles LICENSE.txt in the root of the repo into the package following guidance here.

Before:
image

After:
image

Could alternatively include an SPDX license expression but this wouldn't include specific wording for the author's copyright

<PropertyGroup>
    <PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>

Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks...I had tried to do this myself but could not find the correct combination of options :(

@adamhathcock adamhathcock merged commit deddf12 into adamhathcock:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants