Ignores UnicodePathExtra if forced encoding is specified #696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnicodePathExtra
always overriding specified encoding makes this impossible for some files.Forced
encoding doesn't seem to be used anywhere, other than shadowingDefault
. That basically makes the two fields equivalent. Shouldn't it overrideUnicodePathExtra
? Anyway, I think this is the intended behavior, instead of the current one.