Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Searching Data Descriptor stream issue/pull #680 #727

Merged

Conversation

Erior
Copy link
Contributor

@Erior Erior commented Feb 19, 2023

A solution for the problem described in #680

@adamhathcock
Copy link
Owner

Can you resolve this? I've been away for personal reasons.

@Erior
Copy link
Contributor Author

Erior commented Mar 1, 2023

The xz pull introduced a potential span position counting bug, did not add checks for it, but merged and fixed it. The code for dealing with the non compressed streamed zip files still works okay in the tests.

Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like it but it works well as far as I can tell 👍

@adamhathcock adamhathcock merged commit 42ddb0d into adamhathcock:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants