Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when output filename is an url #18

Merged
merged 1 commit into from Sep 7, 2022
Merged

Fix error when output filename is an url #18

merged 1 commit into from Sep 7, 2022

Conversation

JOJ0
Copy link
Collaborator

@JOJ0 JOJ0 commented Sep 2, 2022

  • Fixes Alternate metadata sources that add a URL as mb_trackid cause xtractor JSON write to fail #16
  • mb_trackid contains an URL populated by some metadata source plugins (eg.
    bandcamp)
  • use the md5 filename generation lines (that were already there for cases
    where mb_trackid is not present at all) in case mb_trackid contains a slash
    (/) character
  • could be advanced later if other unwanted characters populated by source
    plugins are found in mb_trackid but should be a good enough for now fix.

- Fixes #16
- mb_trackid contains an URL populated by some metadata source plugins (eg.
  bandcamp)
- use the md5 filename generation lines (that were already there for cases
  where mb_trackid is not present at all) in case mb_trackid contains a slash
  (/) character
- could be advanced later if other unwanted characters populated by source
  plugins are found in mb_trackid but should be a good enough for now fix.
@JOJ0
Copy link
Collaborator Author

JOJ0 commented Sep 2, 2022

Hi @adamjakab I'll try to submit some fixes that were reported as issues as well as add som things I think are useful with my own current "experiments" on getting the plugin running.

How should we proceed with dev in general? I know you are a busy man but quick reviews/approvals from you would help me a lot. This one should be a no-brainer though, since @doctorfree uses it in his latest musicplayerplus release already. I think it's a perfectly fine fix.

I'll submit some more fixes and addition in the next hours/days and I'll try to keep them tiny so they are quick to review.

@JOJ0 JOJ0 merged commit f98f180 into master Sep 7, 2022
@JOJ0 JOJ0 deleted the fix16_filename branch September 7, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant