Support auto-detection of threads / Note on tilde expansion in README #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to merge my latest PR's without a review from your end @adamjakab and hope you will be fine with it. I'm feeling a little more confident with the codebase by now, and might be able to help users or even fix tiny things when new issues are popping up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these two changes hanging around in devel branch. I tested it on my own (Linux) machine, threads count is detected fine. I reviewed the usage of self.cfg_threads further on in the code, and think it's used correctly (since obviously is the same variable as the default of 1 threads uses). You might have reasons why you didn't merge it into master yet or it was just a lack of time issue and it got forgotten? Thanks for a quick review.
Also I reviewed the valuable addition to the README describing that tilde expansion should be avoided. I also came across an issue where it was reported/discussed and I think this change is perfectly fine and should go into master as soon as possible.