Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhead text color picker #142

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

adamk33n3r
Copy link
Owner

@adamk33n3r adamk33n3r commented Apr 23, 2024

Summary by CodeRabbit

  • New Features

    • Added the ability for users to customize the color of overhead text in notifications.
    • Introduced a color picker with reset functionality on right-click for selecting text colors.
  • Enhancements

    • Improved color picker interactions, including support for alpha transparency and reset to default color.
  • Version Updates

    • Updated build version to enhance application stability and performance.

@adamk33n3r adamk33n3r linked an issue Apr 23, 2024 that may be closed by this pull request
Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The update enhances the Overhead notification feature in the RuneLite Watchdog plugin by allowing users to customize the text color. It introduces a new textColor field in the Overhead class, updates UI components to include a color picker, and integrates color selection functionality. Additionally, it involves minor version updates and improves the color picker utility to handle alpha values and reset actions.

Changes

File Path Changes
.../watchdog/notifications/Overhead.java Added textColor field with getters and setters; updated fireImpl method to use textColor.
.../watchdog/ui/notifications/panels/OverheadNotificationPanel.java Updated constructor to include ColorPickerManager; added ColorJButton for color selection.
.../watchdog/ui/panels/NotificationsPanel.java Passed colorPickerManager to OverheadNotificationPanel constructor.
.../watchdog/ui/panels/PanelUtils.java Enhanced createColorPicker for alpha display and added reset functionality on right-click.
.../watchdog/version.properties Updated VERSION_BUILD from 4633 to 4639; adjusted timestamp.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f987568 and 82e4ea5.
Files selected for processing (5)
  • src/main/java/com/adamk33n3r/runelite/watchdog/notifications/Overhead.java (2 hunks)
  • src/main/java/com/adamk33n3r/runelite/watchdog/ui/notifications/panels/OverheadNotificationPanel.java (1 hunks)
  • src/main/java/com/adamk33n3r/runelite/watchdog/ui/panels/NotificationsPanel.java (1 hunks)
  • src/main/java/com/adamk33n3r/runelite/watchdog/ui/panels/PanelUtils.java (3 hunks)
  • src/main/resources/com/adamk33n3r/runelite/watchdog/version.properties (1 hunks)
Additional comments not posted (5)
src/main/resources/com/adamk33n3r/runelite/watchdog/version.properties (1)

1-2: Version and timestamp updated correctly for the new build.

src/main/java/com/adamk33n3r/runelite/watchdog/ui/notifications/panels/OverheadNotificationPanel.java (1)

14-29: Constructor updated to include color picker functionality correctly.

src/main/java/com/adamk33n3r/runelite/watchdog/notifications/Overhead.java (1)

43-59: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [25-56]

New textColor field correctly used in fireImpl method to apply text color.

src/main/java/com/adamk33n3r/runelite/watchdog/ui/panels/NotificationsPanel.java (1)

123-123: colorPickerManager correctly passed to OverheadNotificationPanel.

src/main/java/com/adamk33n3r/runelite/watchdog/ui/panels/PanelUtils.java (1)

228-239: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [222-245]

Updated createColorPicker method to handle color display and reset functionality correctly.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adamk33n3r adamk33n3r merged commit e5d932b into master Apr 28, 2024
1 check passed
@adamk33n3r adamk33n3r deleted the 128-color-picker-for-overhead branch April 28, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker for overhead
1 participant