Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config dir permissions are getting double-set #19

Closed
ewr opened this issue Mar 14, 2015 · 2 comments · Fixed by #20
Closed

Config dir permissions are getting double-set #19

ewr opened this issue Mar 14, 2015 · 2 comments · Fixed by #20

Comments

@ewr
Copy link

ewr commented Mar 14, 2015

There are two places in the cookbook that are creating the config dir, and they're setting different permissions...

In the service recipe:

# Create service directories
consul_template_directories.each do |dirname|
directory dirname do
owner consul_template_user
group consul_template_group
mode 0755
end
end

In the config provider:

# Ensure config directory exists
directory node['consul_template']['config_dir'] do
user consul_template_user
group consul_template_group
mode node['consul_template']['template_mode']
recursive true
action :create
end

I'm guessing that the 0755 that the service recipe sets is probably correct for the directory, and that the config provider should be using that (and just using node['consul_template']['template_mode'] for the template config file). As it is now, the config resource is always setting its changed flag, which is causing our wrapper template to restart consul-template unnecessarily.

@adamkrone
Copy link
Owner

Thanks for pointing this out. It should now be fixed on master.

@ewr
Copy link
Author

ewr commented Mar 18, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants