Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved hashes to bottom of file #16

Merged
merged 2 commits into from Mar 4, 2015
Merged

Moved hashes to bottom of file #16

merged 2 commits into from Mar 4, 2015

Conversation

franklinwise
Copy link
Contributor

Since the hash list will grow endlessly, let's put it on the bottom of the file, that way the handful of attributes that are available to customize are all at the top and together.

Since the hash list will grow endlessly, let's put it on the bottom of the file, that way the handful of attributes that are available to customize are all at the top and together.
@adamkrone
Copy link
Owner

In the future, I'm considering limiting the checksums to the newest X versions, so it probably won't grow endlessly, but I haven't decided how many that will be. Still, I agree that it makes sense to isolate it from the other attributes.

Instead of moving it to the bottom, why don't we just move it to a new file (attributes/checksums.rb)? Could you make that change?

Thanks for the help!

@franklinwise
Copy link
Contributor Author

Makes sense. I committed an update with the change.

@adamkrone
Copy link
Owner

Awesome, thanks again.

adamkrone added a commit that referenced this pull request Mar 4, 2015
Moved hashes to bottom of file
@adamkrone adamkrone merged commit c69cfbf into adamkrone:master Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants