Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure config directory exists #18

Merged
merged 2 commits into from Mar 7, 2015

Conversation

franklinwise
Copy link
Contributor

when I ran this provider I discovered that the config directory didn't exist, so I added the creation if it doesn't exist.

@tgwizard
Copy link
Contributor

tgwizard commented Mar 6, 2015

@franklinwise
Copy link
Contributor Author

Yes, and that creates an ordered dependency between the provider and the service recipe making the provider unusable without setting up the service. The configs should be created before the service starts anyways. So if I want to call the provider in a separate recipe to register the config from outside this project, I can't do it without this change.

@adamkrone
Copy link
Owner

Makes sense. Can you just fix the recursive and action lines to be spaces instead of tabs?

Thanks

@franklinwise
Copy link
Contributor Author

updated

@adamkrone
Copy link
Owner

Awesome, thanks again!

adamkrone added a commit that referenced this pull request Mar 7, 2015
@adamkrone adamkrone merged commit 8b976c1 into adamkrone:master Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants