Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "upstart" init_style #29

Merged
merged 2 commits into from Sep 30, 2015
Merged

added "upstart" init_style #29

merged 2 commits into from Sep 30, 2015

Conversation

eugene-dm
Copy link

upstart is available for CentOS also

@adamkrone
Copy link
Owner

@eugene-dm sorry, I missed the notification when you opened this PR.

I'd like to merge this, but before I do can you update a few things?

  • keep the version in metadata.rb the same (after I merge this I will be releasing this, and some other changes, as v0.9)
  • fix the case indentation in service.rb (case and when/else should be at same level). This follows the ruby styleguide and is enforced with rubocop.
  • fix the indentation of the arguments starting on lines 90, 109, and 120 of service.rb. Indentation should be 2 spaces. Same as above, this is laid out in the ruby styleguide.

The last two items should fix all the travis-ci errors. You can run bundle exec rake locally to validate rubocop/tests pass before pushing up your fixes.

@eugene-dm
Copy link
Author

@adamkrone, I've updated styles, so checks are passed and you can merge this pull request

@adamkrone
Copy link
Owner

@eugene-dm awesome, thanks a lot!

adamkrone added a commit that referenced this pull request Sep 30, 2015
added "upstart" init_style
@adamkrone adamkrone merged commit b4acd7e into adamkrone:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants