New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chef12 compatibility #89
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reload systemd when template changes. If the systemd template is changed, we need to ensure we perform a reload prior to restarting the consul-template service. Without this the changes will not be picked up. * Change systemd service file to be non-executable There's no reason for it to be, and systemd doesn't like it, on Ubuntu 16.04.2 LTS at least: dmesg: systemd-sysv-generator[4385]: Configuration file /etc/systemd/system/consul-template.service is marked executable. Please remove executable permission bits. Proceeding anyway. * update checksums for v0.18.0 * Added checksums for v0.19.0 * unpinned nssm version depedency * updated suites with the correct centos-7.3 * adding custom consul/vault addr options * break long line * Fix checksums after merge * Add 0.19.4 checksums and update default version * Pin Test Kitchen to Chef 12 Will address Chef 13 compatibility soon, this just gets the test suite working again. * Updates test kitchen OS matrix Removes Ubuntu 12.04 and Debian 7.11, adds Debian 9.3, updates Debian 8 and CentOS 6 and 7 minor versions * Debian 9.3 box hasn't been created yet * Removes support for supervisor While I hate to remove functionality, the supervisor cookbook depends on the deprecated python cookbook. This appears to be the only issue preventing Chef 13 compatibility, so it has to go. I'm not against adding this back in at some point in the future, if the compatibility situation is fixed. * Remote constraint on golang * Update ruby version * Rubocop fixes * Foodcritic fixes * Debian 8.10 box hasn't been created yet * Allow specification of environment variables in init templates * Removes installation from source for now It looks like this has probably been broken for a while, so I'm disabling it until I get a chance to rewrite it. * Update CHANGELOG * Mark default.json as sensitive resource Closes adamkrone#71 * Adds ExecStop to systemd service Closes adamkrone#72 * Update CHANGELOG * Updates OS support in metadata * v0.13.0 release
tas50
reviewed
May 18, 2018
- name: debian-7.11 | ||
- name: centos-6.8 | ||
- name: centos-7.3 | ||
- name: debian-9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change these to just debian-9 to get the slugs we push up for Bento. Every bento release updates them and as long as you keep the boxes up to date you'll always have the latest point release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.