-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move un-/register new extensions to the config files #6
Comments
That's a very good idea. It should be as simple as adding the My choice would be to use the SM name of the extension's main class (
And the onBootstrap code would look something like this:
If you would like to send a PR for this you're more than welcome to :) If not I'll make some time to implement it in the next few days. |
I will try to make a PR tomorrow, at least until tuesday. Thanks for being open to new ideas. |
I decided to move the register and unregister action to the factory. The |
Fixed in #8 |
It would be better, if the registering and unregistering of extensions could be achieved with the configuration, instead of using the onBootstrap() hook in every module.
Something like:
Please tell me, if you think this is good. I can try to make a PR for it, if you want to.
The text was updated successfully, but these errors were encountered: