Fix command sanitisation

adammcdonagh · Jul 4, 2023 · 29a881c · 29a881c
1 parent 4bd9992
commit 29a881c
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/opentaskpy/remotehandlers/ssh.py b/src/opentaskpy/remotehandlers/ssh.py
@@ -949,8 +949,6 @@ def kill(self) -> None:
             f"[{self.remote_host}] Killing remote processes with command: {command}"
         )
 
-        # Sanitise the command
-        command = quote(command)
         # Make sure we're not killing PID 1 or 0
         if command in ("kill 1", "kill 0"):
             self.logger.error(
@@ -974,13 +972,11 @@ def execute(self) -> bool:
         try:
             self.connect()
 
-            # Command needs the directory to be changed to appended to it
-            # Sanitise the command
-            command = quote(self.spec["command"])
             directory = quote(self.spec["directory"])
 
             command = (
-                f"echo __OTF_TOKEN__$$_{self.random}__; cd {directory} && {command}"
+                f"echo __OTF_TOKEN__$$_{self.random}__; cd {directory} &&"
+                f" {self.spec['command']}"
             )
 
             self.logger.info(f"[{self.remote_host}] Executing command: {command}")