Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for require `minitest-stub-const' #3

Merged
merged 1 commit into from Jan 22, 2015
Merged

Add support for require `minitest-stub-const' #3

merged 1 commit into from Jan 22, 2015

Conversation

mptre
Copy link
Contributor

@mptre mptre commented Jan 22, 2015

When using this gem with Bundler one has to explicit require the gem or define a require path in the Gemfile.

Before:

gem "minitest-stub-const", require: "minitest-stub_const"

After:

gem "minitest-stub-const"

@adammck
Copy link
Owner

adammck commented Jan 22, 2015

This is due to me being an idiot and naming the repository (and gem) wrongly. I should have called it minitest-stub_const, to adhere to the Gem naming conventions. It's a bit late now. But this (obvious, in hindsight) fix makes things much better. Thanks!

adammck added a commit that referenced this pull request Jan 22, 2015
Add support for require `minitest-stub-const'
@adammck adammck merged commit 074f982 into adammck:master Jan 22, 2015
@mptre
Copy link
Contributor Author

mptre commented Jan 22, 2015

Great! Could you bump the version and release?

@adammck
Copy link
Owner

adammck commented Jan 22, 2015

Done. Would you mind giving it a try, and letting me know?

@mptre
Copy link
Contributor Author

mptre commented Jan 22, 2015

Works like a charm!

@adammck
Copy link
Owner

adammck commented Jan 22, 2015

Great, thanks for testing! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants