Terraform 0.12+ index can be string or number #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of when mixing resources into the statefile in terraform, it's now
possible to have indexes that are not always int. In the example below using the
new 0.12 syntax `foreach` will result in the index being mapped to the
`each.key` name instead of the integer indexes.
```
variable "test" {
default = {"testa" = "1.1.1.1", "testb" = "2.2.2.2"}
}
resource "aws_route53_record" "this" {
for_each = var.test
zone_id = "abc"
name = "${each.key}.tv."
type = "A"
ttl = "300"
records = [each.value]
}
```
adammck
reviewed
Dec 20, 2019
| @@ -125,7 +126,7 @@ func (r Resource) Tags() map[string]string { | |||
| t[kk] = vv | |||
| } | |||
| } | |||
| case "aws_instance", "linode_instance": | |||
| case "serverscom_dedicated_server", "aws_instance", "linode_instance": | |||
There was a problem hiding this comment.
This seems to be a separate feature. Could you please split this into a separate PR?
|
Thank you for the patch! Except for the comment above, this looks good to go. |
|
It doesn't work without changes in resource.go. So I get an error like this: |
|
Merged #139, which includes this. Thanks very much for the original PR. Please re-open this if your issue isn't resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of when mixing resources into the statefile in terraform, it's now
possible to have indexes that are not always int. In the example below using the
new 0.12 syntax
foreachwill result in the index being mapped to theeach.keyname instead of the integer indexes.