Stop creating groups for tfstate attribute counts #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonnymcc
force-pushed
the
group-counts
branch
from
31e4912
to
3b5e97d
Compare
|
This looks good, but would you mind adding a couple of examples to the fixture in parser_test.go? |
adammck
reviewed
Jun 9, 2017
resource.go
Outdated
|
|
||
| switch r.resourceType { | ||
| case "aws_instance": | ||
| for k, v := range r.Attributes() { | ||
| parts := strings.SplitN(k, ".", 2) | ||
| if len(parts) == 2 && parts[0] == "tags" && parts[1] != "#" { | ||
| if len(parts) == 2 && parts[0] == "tags" && !tf_count.MatchString(parts[1]) { |
There was a problem hiding this comment.
I think parts[1] != "#" && parts[1] != "%" would be clearer, here. Could we also get a comment reminding us why we might encounter either symbol? I'm assuming it's a change between Terraform versions.
added 2 commits
June 9, 2017 14:01
The count attribute key in state files has changed from # to %
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform-inventorycurrently creates groups like the following...{"%_5":["10.95.12.224"],"%_6":["53.81.162.94"], ...This ensures these groups do not get created.