Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages are not cleaned #683

Closed
adamralph opened this issue Mar 4, 2022 · 5 comments · Fixed by #684 or #705
Closed

Packages are not cleaned #683

adamralph opened this issue Mar 4, 2022 · 5 comments · Fixed by #684 or #705
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@adamralph
Copy link
Owner

adamralph commented Mar 4, 2022 •
edited

Version(s)

1.0.0 to 2.5.0.

To reproduce

Steps to reproduce the behaviour:

  1. Create a class library
  2. Add a package reference to MinVer 2.5.0
  3. Run dotnet build
  4. Run dotnet pack
  5. Run dotnet clean

Expected behaviour

The package is deleted from disk.

Actual behaviour

The package is not deleted from disk.

Workarounds

Delete the package from disk in a separate action.

Additional context

Thanks to @xoofx for prompting the discovery of this problem by raising #675.
@adamralph adamralph added the bug Something isn't working label Mar 4, 2022
@adamralph adamralph added this to the 3.0.0 milestone Mar 4, 2022
This was referenced Mar 4, 2022
Merged
Merged
@adamralph adamralph linked a pull request Mar 4, 2022 that will close this issue
fix target injection for clean and pack #684
Merged
@adamralph
Copy link
Owner Author

fixed in #684

@adamralph
Copy link
Owner Author

released in 3.0.0-rc.2

@adamralph
Copy link
Owner Author

see #681 (comment)

@adamralph adamralph reopened this Mar 8, 2022
This was referenced Mar 8, 2022
Merged
Merged
@adamralph adamralph linked a pull request Mar 8, 2022 that will close this issue
don't run MinVer before Clean when packages are not generated on build #705
Merged
@adamralph
Copy link
Owner Author

re-closed by #705

@adamralph
Copy link
Owner Author

re-released in 3.0.0-rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
1 participant
@adamralph